Issue #3013 has been updated by Ricky Zhou.
Any luck reproducing that select weirdness? That seems to be the only
significant difference between our patches, and I think select would be a
little cleaner and simpler than using timeout. Note that if the timeout occurs
right after the sysread/readpartial call and before the timer thread finishes,
it looks like this will drop data:
<pre>
output << timeout(1) {
output_read.send(method,1)
# timeout happens right here
} while true
</pre>
I'm also not crazy about reading the output in one byte at a time. That's a
lot of syscall overhead, especially for large outputs.
----------------------------------------
Bug #3013: util.rb:execute broken on Ruby <1.8.3
http://projects.reductivelabs.com/issues/3013
Author: Ricky Zhou
Status: Ready for Testing
Priority: Urgent
Assigned to: Markus Roberts
Category: exec
Target version: 0.25.3
Affected version: 0.25.2
Keywords:
Branch: http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/3013
Apparently the patch in ticket #2731 introduced one more issue by using
readpartial, which isn't available until ruby 1.8.3 (RHEL4 at least is
affected). I'm not sure how this is normally handled in ruby, but if the
readpartial function is not available, the code should fall back to sysread
(along with some code for handling EINTR).
Anybody with better ruby knowledge know how this should be done?
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://reductivelabs.com/redmine/my/account
-- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
