Jira (PUP-5761) when puppet module-level data provider function defines an unqualified key, puppet lookup returns nothing

[Sean Griffin (JIRA)]

Title: Message Title

Sean Griffin created an issue   Puppet / PUP-5761 when puppet module-level data provider function defines an unqualified key, puppet lookup returns nothing Issue Type: Bug Assignee: Unassigned Created: 2016/01/28 12:43 AM Priority: Normal Reporter: Sean Griffin Define a module level data provider function, either puppet function or ruby function like this: [root@b8pwin0w4p7demn ~]# cat /etc/puppetlabs/code/environments/production/modules/hello/lib/puppet/functions/hello/data.rb Puppet::Functions.create_function(:'hello::data') do def data() { 'hello::module_key' => 'module-hello-ruby-function provided data', 'global_key' => 'module-hello-ruby-function provided data', } end end [root@b8pwin0w4p7demn ~]# That is, defining two key-value pairs, one qualified with the name of the module (hello::module_key), the other unqualified (global_key). Now try to lookup hello::module_key. We get nothing, exit code 1 indicating the key was not found. --explain does not help. [root@b8pwin0w4p7demn ~]# puppet lookup hello::module_key [root@b8pwin0w4p7demn ~]# echo $? 1 [root@b8pwin0w4p7demn ~]# puppet lookup hello::module_key --explain   [root@b8pwin0w4p7demn ~]# echo $? 0 [root@b8pwin0w4p7demn ~]# Now comment out the second definition in data.rb and try again. [root@b8pwin0w4p7demn ~]# vi /etc/puppetlabs/code/environments/production/modules/hello/lib/puppet/functions/hello/data.rb [root@b8pwin0w4p7demn ~]# cat /etc/puppetlabs/code/environments/production/modules/hello/lib/puppet/functions/hello/data.rb Puppet::Functions.create_function(:'hello::data') do def data() { 'hello::module_key' => 'module-hello-ruby-function provided data', # 'global_key' => 'module-hello-ruby-function provided data', } end end [root@b8pwin0w4p7demn ~]# puppet lookup hello::module_key --- module-hello-ruby-function provided data ... [root@b8pwin0w4p7demn ~]# puppet lookup hello::module_key --explain Merge strategy first Data Binding "hiera" No such key: "hello::module_key" Data Provider "EnvironmentDataProvider" No such key: "hello::module_key" Module "hello" using Data Provider "FunctionModuleDataProvider" Found key: "hello::module_key" value: "module-hello-ruby-function provided data" Merged result: "module-hello-ruby-function provided data" [root@b8pwin0w4p7demn ~]# Now the lookup of the same key succeeds. Apparently, unqualified keys-value pairs in the function cause the lookup to abort. I feel an error message is deserved if the lookup aborts due to the presence of an unqualified key in the function's hash. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.