Jira (FACT-1373) Facter with external fact containing a facter call fork-bombs the node

[John Duarte (JIRA)]

Title: Message Title

John Duarte updated an issue   Facter / FACT-1373 Facter with external fact containing a facter call fork-bombs the node Change By: John Duarte If you have an external fact that contains a call to facter, the machine begins to fork-bomb itself and usually control cannot be regained of the system if you cannot quickly get all puppet processes killed. Example fact: datacenter.sh {code} #!/bin/bash prefix=`facter ipaddress |awk -F "." '{print $1"."$2"."$3}'` case "$prefix" in   10.1.2)     echo "datacenter=foo"     ;;   10.2.3)     echo "datacenter=bar"     ;;   *)      echo "This is an unknown location."      ;; sac {code} This outputs the location of a datacenter based on subnet.  If this script is run "as is" as an external fact by placing it in /etc/puppetlabs/facter/facts.d and you run "facter datacenter", facter begins to compound upon itself until it consumes all resources on the system, and must be rebooted. The workaround I use (provided by Ben Ford) is: datacenter.sh {code} #!/bin/bash prefix=`facter ipaddress --no-external-facts |awk -F "." '{print $1"."$2"."$3}'` case "$prefix" in   10.1.2)     echo "datacenter=foo"     ;;   10.2.3)     echo "datacenter=bar"     ;;   *)      echo "This is an unknown location."      ;; sac {code} And this works fine. Desired result would be that facter would recognize it is running an external fact already, and should assume "--no-external-facts" to prevent the fork-bomb behavior and/or some other mechanism internally to facter that would prevent the fork-bomb. ------ *Update* The resolution of this issue will prevent the fork-bomb condition by performing the following # The recursive condition will be caught # External facts will be skipped # A warning will be presented alerting the user to modify their external fact to call {{facter}} with {{--no-external-facts}} Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.