Jira (PUP-6989) Acceptance testing using TYPE=git and preserved hosts is broken

[Thomas Hallgren (JIRA)]

Title: Message Title

Thomas Hallgren created an issue   Puppet / PUP-6989 Acceptance testing using TYPE=git and preserved hosts is broken Issue Type: Bug Assignee: Unassigned Created: 2016/12/08 8:00 AM Priority: Normal Reporter: Thomas Hallgren I tried to use the acceptance tests with TYPE=git today and ran into several problems. All tests using the latest master fails on missing semantic_puppet. This is because it is missing from the config/git/options.rb and also from the install.rb. Adding semantic_puppet to install.rb doesn't work because it lacks an install.rb of its own. The Rake command ci:list_preserved is broken. It looks for files directly under the log directory. The files however, resides one level down, under log/<config>. Once I got ci:list_preserved working, I found that the ci:test_against_preserved_hosts is also broken. It does not propagate preserved hosts correctly (a variable named config is assumed to be present at line 123, but it isn't and instead a method is called that picks a host seemingly at random). I used the temporary fix of setting config = final_options[:hosts_file] to get around this but then it breaks with other commands. Without this functionality working, it's very hard to assert that changes made to the code will not break once the reach the CI-pipeline. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.