Issue #4308 has been updated by James Turnbull. Status changed from Re-opened to Closed
Sorry - did not tell you we'd worked out your patch wasn't at fault. ;) Pushed in commit:"07d0be4684f75e6edc6fbb5d1397dd79b8ca2b6b" ---------------------------------------- Refactor #4308: Remove puppettest from spec_helper http://projects.puppetlabs.com/issues/4308 Author: Matt Robinson Status: Closed Priority: Normal Assignee: James Turnbull Category: testing Target version: 2.6.1 Affected version: 2.6.0 Branch: http://github.com/mmrobins/puppet/tree/ticket/master/4308-remove_puppettest_from_specs puppettest.rb is used for unit tests and loads and requires everything under the sun in the unit test directory. spec_helper was just requiring puppettest which means it got a lot of stuff loaded for all the specs that wasn't necessary. There have been a few tests in the past were unexpected things in the spec_helper or puppettest had caused problems, and cleaning unnecessary code out of those files makes it easier to reason about what the tests are doing. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
