Issue #4798 has been updated by Paul Berry.

Assignee set to Paul Berry

I've been able to reproduce the failure described by Ryan Coleman in comment 5. 
 It is a regression in version 2.6.  What's happening is that puppet doc is 
trying to document both the modules (which are located at /tmp/puppet/modules) 
and the site-specific files (which it assumes are located at /tmp/puppet, the 
directory site.pp is in).  Since it doesn't realize that one of these 
directories is a subdirectory of the other, its efforts to parse both of them 
cause some files (like /tmp/puppet/modules/rt/manifests/rt.pp) to get parsed 
twice.

In 0.25.x, this was not a problem, because puppet doc creates a fresh parser to 
parse every file, and as a result the parser didn't notice that it was trying 
to process the same file twice.  But in 2.6.x, we've shifted responsibilities 
around so that Puppet::Resource::TypeCollection keeps track of what files have 
been imported.  As a result, the parser now notices that it's being asked to 
parse a file twice, and it reports an error, which halts puppet doc.

I'm working on a fix for this.  But I'm not certain that it's the same problem 
that James originally reported.

James, In your bug report the path you mentioned for your site.pp file was 
"/path/to/site.pp".  Do you recall what path you actually used when you tested 
this?  If it was something inside "/tmp/doc", then the problem you experienced 
on Friday is the same as the bug I've found.  If not, then we are looking at 
different bugs and we'll need to investigate your bug more deeply.
----------------------------------------
Bug #4798: Puppet doc manifests documentation mode broken
http://projects.puppetlabs.com/issues/4798

Author: James Turnbull
Status: Accepted
Priority: High
Assignee: Paul Berry
Category: documentation
Target version: 2.6.2
Affected version: 2.6.0
Keywords: 
Branch: 


In 2.6.1 (and looks like 2.6.0 also) the puppet doc manifests documentation is 
busted.

<pre>
$ puppet doc -o /tmp/doc -m rdoc /path/to/manifests/site.pp --debug
</pre>

Outputs:
<pre>
info: scanning: ["tmp/doc", "/path/to/manifests/site.pp"]
</pre>

And produces zilch output.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to