Issue #4860 has been updated by Matt Robinson. Status changed from Ready for Testing to Ready for Checkin Branch changed from http://github.com/Savar/puppet/commit/25595ccb4549ab815b55596e33f2893c32bad2e2 to http://github.com/mmrobins/puppet/tree/ticket/master/4860
I wanted to add some regression tests to the patch. When I looked, there were already tests, but they overly mocked the test objects so weren't useful for identify the problem that Simon fixed. I modified the tests accordingly and will send the patch to the list. Technically, that means this has been tested as I also ran the puppet rdoc command and didn't get the error, but I'll let someone else move this to ready for checkin after the patch goes to the list. Okay, Markus already marked it ready for testing. I think it will be okay for me to mark it ready for checking since I've tested it and added tests. ---------------------------------------- Bug #4860: Wrong method name "params". http://projects.puppetlabs.com/issues/4860 Author: Simon Effenberg Status: Ready for Checkin Priority: Normal Assignee: Category: executables Target version: 2.6.2 Affected version: 2.6.1 Keywords: Branch: http://github.com/mmrobins/puppet/tree/ticket/master/4860 When trying to generate a puppet doc for my puppet manifest with: puppet doc --mode rdoc --outputdir /tmp/rdoc -a i got: Could not generate documentation: impossible to parse class 'base' in /etc/puppet/modules/filesync/manifests/defines/share.pp at line 52: impossible to parse resource in /etc/puppet/modules/filesync/manifests/defines/share.pp at line 55: undefined method `params' for #<Puppet::Parser::AST::Resource:0x7ffb5f2f75f8> after debugging it the problem seems to be that a refactoring commit 0d704686b923c7827b9fe16f20d4f8722c125d88 wasn't clean (the referenced call wasn't found). Fixed in commit http://github.com/Savar/puppet/commit/25595ccb4549ab815b55596e33f2893c32bad2e225595ccb4549ab815b55596e33f2893c32bad2e2 -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
