Issue #4945 has been updated by Nick Lewis.
I agree with your proposed fix. I didn't realize that InstallOptions.man was only for the creation of man pages, not their installation. In that case, it's unused, because the one line that uses it: `build_man(bins, sbins) if InstallOptions.man` is commented out. Also, it appears we have underscored and non-underscored versions of all of our dir options. InstallOptions.mandir holds the value from the command line option, and InstallOptions.man_dir holds the value that actually gets used (most specifically in the case where the command line option is nil). ---------------------------------------- Bug #4945: The fix for #4644 breaks man page instalation. http://projects.puppetlabs.com/issues/4945 Author: Markus Roberts Status: Code Insufficient Priority: Normal Assignee: Markus Roberts Category: Target version: 2.6.2 Affected version: 2.6.2rc1 Keywords: Branch: git://jet.mox.net/~tmz/puppet.git tickets/2.6.x/4644 As reported by Todd Zullinger, the patch had an unintended side-effect on non-windows systems: Man pages are now no longer installed unless rdoc/ronn are present. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
