Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on PUP-8240   Re: ERB and EPP templates handle CRLF line endings inconsistently That is so sad... Is the design really that the read is supposed to not preserve line endings? That is bizarre. The posix implementation does not remove CR chars (and I don't think it should) - that is why it works on non-windows. Seems more natural that there would be a special read that strips CR that logic not prepared to handle CRLF line endings should use. While we could change this for the EPP loader, all other modern loaders of code uses read - so an inline template doing the same thing would have the same issue. If we change the Posix read to strip CR then that is a serious performance issue (we need to read and replace them which would mean scanning the read manifest again. To me the proper fix is to modify the Windows implementation so that read is the same as read_preserve_line and that we add another read method read_posix_line_endings that should be used where reads on windows where supposed to get posix line endings (if that is needed anywhere at all?). Or... am I perhaps missing some Ruby quirk around CRLF line endings? Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.