Issue #5325 has been updated by Paul Nasrat. Status changed from Unreviewed to Accepted
Thanks for the patch - the process for review is generally documented here: http://projects.puppetlabs.com/projects/puppet/wiki/Development_Development_Lifecycle Some things based on an initial scan - I'd rather use Facter::Util::Resolution.exec rather than %x{} Does prtdiag need to be run as root? What happens if it is run as a non-root user? Can you attach to the bug sample output of prtdiag as it may be useful for other features. Thanks ---------------------------------------- Bug #5325: Manufacturer and product name on SPARC https://projects.puppetlabs.com/issues/5325 Author: Dominic Cleal Status: Accepted Priority: Normal Assignee: Category: library Target version: Keywords: sparc solaris Branch: The manufacturer and productname facts are missing on SPARC, as the SunOS code in util/manufacturer.rb assumes it can use smbios (unavailable). Attached is a simple patch that instead uses prtdiag when running under SunOS *and* SPARC to fetch the manufacturer and product. No attempt is made to use prtdiag under x86 as well. Example output: manufacturer => Sun Microsystems productname => Sun SPARC Enterprise M3000 Server -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
