Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019

[Enis Inan (JIRA)]

Title: Message Title

Enis Inan commented on FACT-1889   Re: Windows operating system facts should resolve correctly for Server 2019 Modifying https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/win... to do something like: if consumerrel {   result.release = "10" } elseif (buildno >= 17623) {   result.release = "2019" } else {   result.release = "2016" } would work. I've (informally) tested this on our Windows Server 2016 and Windows Server 2019 machines. Note that 17623 is the lowest build number for the Windows Server 2019 series based on https://en.wikipedia.org/wiki/Windows_Server_2019. Also confirmed with John O'Connor that this is the correct approach for this ticket until we finish FACT-1881, whereby we could consider cleaning this up. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.