Jira (PUP-9498) Calling hiera first nullifies lookup_options.

[Steve Traylen (JIRA)]

Title: Message Title

Steve Traylen updated an issue   Puppet / PUP-9498 Calling hiera first nullifies lookup_options. Change By: Steve Traylen This change in behaviour occurred between 5.4.0 and 5.5.0 If the hiera function is called on a module namespace $a = hiera(module::foo) before any lookup call $ = lookup('module::bar) on that same namespace then lookup_options on the module level data is never looked up. All subsequent lookups (or hiera) can then be wrong. Attached is a test case module. bundle install # The following command will fail tests bundle exec rake test     # The following command will pass tests PUPPET_VERSION=5.4.0 bundle update PUPPET_VERSION=5.4.0 bundle exec rake test The failing file is {noformat} class lookupparam::hierafirst {   $notusedhiera = hiera('lookupparam::notusedhiera',foobar)                       $notusedlookup = lookup('lookupparam::notusedlookup',String,'first',foobar)   $testparam = lookup('lookupparam::testparam')   notify{$testparam:} }                      {noformat} The call  of hiera('lookupparam::notusedhiera') is enough to beak break all the other lookups and in particular in this case $testparam ignores the lookup_options which are present in the module  level data. In addition this hardly ever happens in real would since modules typically have parameters and that is enough to cause the lookup. The particular case where we run into this was    {noformat} class whatever (    $a = 'abc', ) inherits whatever::params { ... } class whatever {   $myvar = hiera('whatever::param') } {noformat} Closing this won't fix is fine with me. To trigger this you must use the deprecated hiera  function and lookup_options in the same module and that is probably a bad idea anyway. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.