Jira (PUP-9942) no_proxy environment variable does not work

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper updated an issue   Puppet / PUP-9942 no_proxy environment variable does not work Change By: Josh Cooper Commit 90560edf0f43f5382bd539646988f7a96ea3809e for PUP-4030 added the ability to skip an http proxy if the host and port matched an entry in the {{NO_PROXY}} environment variable. However it didn't actually work because our connection factory passed the {{Site}} object instead of a String or URI. To reproduce specify an unused http proxy port and try to not use a proxy for the puppet server: {noformat} $ env NO_PROXY=$(bundle exec puppet config print server --section main) bundle exec puppet agent -t --http_proxy_host localhost --http_proxy_port 12345 Warning: Unable to fetch my node definition, but the agent run will continue: Warning: Failed to open TCP connection to localhost:12345 (Connection refused - connect(2) for "localhost" port 12345) Info: Retrieving pluginfacts Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/facts.d]: Failed to generate additional resources using 'eval_generate': Failed to open TCP connection to localhost:12345 (Connection refused - connect(2) for "localhost" port 12345) Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/facts.d]: Could not evaluate: Could not retrieve file metadata for puppet:///pluginfacts: Failed to open TCP connection to localhost:12345 (Connection refused - connect(2) for "localhost" port 12345) ... {noformat}   Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.320046.1565215526000.47502.1565216880078%40Atlassian.JIRA.