Jira (PUP-10308) Puppet.lookup(:current_environment) is wrong if environment changes during convergence

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-10308 Puppet.lookup(:current_environment) is wrong if environment changes during convergence Issue Type: Bug Assignee: Unassigned Created: 2020/02/21 10:11 AM Priority: Normal Reporter: Josh Cooper At the start of the configurer run, puppet pushes its configured environment (from Puppet[:environment]) or the server-specified environment (from the ENC) onto the context in https://github.com/puppetlabs/puppet/blob/6.13.0/lib/puppet/configurer.rb#L319-L331 However, if pluginsync causes environment to change, then the agent switches to the new environment, but Puppet.lookup(:current_environment) still returns old value, while Puppet::Resource::Catalog#environment returns the new value: $ bx puppet agent -t Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Notice: Local environment: 'production' doesn't match server specified environment 'dev', restarting agent run with environment 'dev' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Caching catalog for XXX Info: Applying configuration version '1582308523'   [261, 270] in /Users/josh/work/puppet/lib/puppet/type/file/source.rb 261: end 262: end 263: 264: def each_chunk_from 265: require 'byebug'; byebug => 266: if Puppet[:default_file_terminus] == :file_server && scheme == 'puppet' && (uri.host.nil? || uri.host.empty?) 267: chunk_file_from_disk(metadata.path) { |chunk| yield chunk } 268: elsif local? 269: chunk_file_from_disk(full_path) { |chunk| yield chunk } 270: else (byebug) Puppet.lookup(:current_environment) <Puppet::Node::Environment::Remote:70205531253460 @name="production" @manifest="no_manifest" @modulepath="" > (byebug) resource.catalog.environment "dev" Puppet relies on the catalog's environment being correct when retrieving file metadata & content, such as https://github.com/puppetlabs/puppet/blob/6.13.0/lib/puppet/type/file/source.rb#L194 Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.347236.1582308671000.35404.1582308723706%40Atlassian.JIRA.