Jira (FACT-2589) Fix RSpec warnings

[Gheorghe Popescu (Jira)]

Title: Message Title

Gheorghe Popescu created an issue   Facter / FACT-2589 Fix RSpec warnings Issue Type: Task Assignee: Unassigned Created: 2020/04/28 11:46 PM Priority: Normal Reporter: Gheorghe Popescu There are some RSpec warnings that should be fixed WARNING: Using `expect { }.not_to raise_error(SpecificErrorClass)` risks false positives, since literally any other error would cause the expectation to pass, including those raised by Ruby (e.g. NoMethodError, NameError and ArgumentError), meaning the code you are intending to test may not even get reached. Instead consider using `expect { }.not_to raise_error` or `expect { }.to raise_error(DifferentSpecificErrorClass)`. This message can be suppressed by setting: `RSpec::Expectations.configuration._on_potential_false_positives_ = :nothing`. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/custom_facts/core/aggregate_spec.rb:41:in `block (3 levels) in <top (required)>'. [2020-04-29 09:43:22.564537 ] ERROR Facter - Failed to handle /tmp/foo.yaml as LegacyFacter::Util::Parser::YamlParser facts: no implicit conversion of nil into String [2020-04-29 09:43:22.566776 ] ERROR Facter - Failed to handle /tmp/foo.json as LegacyFacter::Util::Parser::JsonParser facts: no implicit conversion of nil into String WARNING: Using `expect { }.not_to raise_error(SpecificErrorClass)` risks false positives, since literally any other error would cause the expectation to pass, including those raised by Ruby (e.g. NoMethodError, NameError and ArgumentError), meaning the code you are intending to test may not even get reached. Instead consider using `expect { }.not_to raise_error` or `expect { }.to raise_error(DifferentSpecificErrorClass)`. This message can be suppressed by setting: `RSpec::Expectations.configuration._on_potential_false_positives_ = :nothing`. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/custom_facts/util/resolution_spec.rb:105:in `block (3 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/current_zone_resolver_spec.rb:9:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zfs_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zfs_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zfs_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zfs_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zone_resolver_spec.rb:9:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zpool_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zpool_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zpool_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zpool_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zpool_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect, use `and_return(*ordered_values)` instead.. Called from /Users/gheorghe.popescu/Workspace/facter-ng/spec/facter/resolvers/solaris/zpool_resolver_spec.rb:6:in `block (2 levels) in <top (required)>'. Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357116.1588142786000.49864.1588142820064%40Atlassian.JIRA.