Issue #6540 has been updated by Randall Hansen.

I'm not convinced that "status" is the right thing to change here.  E.g., I 
don't think it makes sense for a noop run to indicate "kind: apply" -- that's 
plainly incorrect.  I'd like to find a better way to make these two properties 
useful and correct.
----------------------------------------
Feature #6540: Puppet::Transaction::Report should have status to indicate 
desired noop change
https://projects.puppetlabs.com/issues/6540

Author: Dan Bode
Status: Accepted
Priority: Normal
Assignee: 
Category: 
Target version: 
Affected Puppet version: 2.6.4
Keywords: 
Branch: 


The status is a very useful way to quickly understand what happened in a run. 
There should be a special status to indicate that although nothing changed, 
some things wanted to change, but noop was set.

The below example show a run where --noop=true, the final resulting status is 
'unchanged' I propose that the final result should be noop_changed


<pre>
notice: Compiled catalog for -etc-puppet-foo-dansmodule-tests-init.pp in 
environment foo in 0.04 seconds
notice: Finished catalog run in 0.04 seconds
--- !ruby/object:Puppet::Transaction::Report
  configuration_version: 1298730477
  host: mypuppetmaster
  kind: apply
  logs: []
  metrics: 
    time: !ruby/object:Puppet::Util::Metric
      label: Time
      name: time
      values: 
        - 
          - user
          - User
          - 0.000695
        - 
          - total
          - Total
          - 0.000695
        - 
          - config_retrieval
          - Config retrieval
          - 0
    resources: !ruby/object:Puppet::Util::Metric
      label: Resources
      name: resources
      values: 
        - 
          - total
          - Total
          - 1
    events: !ruby/object:Puppet::Util::Metric
      label: Events
      name: events
      values: 
        - 
          - total
          - Total
          - 0
    changes: !ruby/object:Puppet::Util::Metric
      label: Changes
      name: changes
      values: 
        - 
          - total
          - Total
          - 0
  puppet_version: 2.6.5
  report_format: 2
  resource_statuses: 
    "User[dan]": !ruby/object:Puppet::Resource::Status
      change_count: 0
      changed: false
      evaluation_time: 0.000695
      events: []
      failed: false
      file: /etc/puppet/foo/dansmodule/manifests/init.pp
      line: 4
      out_of_sync: false
      out_of_sync_count: 0
      resource: "User[dan]"
      resource_type: User
      skipped: false
      tags: 
        - user
        - dan
        - class
        - dansmodule
      time: 2011-02-26 08:27:57.894180 -06:00
      title: dan
  status: unchanged
  time: 2011-02-26 08:27:57.882869 -06:00
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to