Issue #4258 has been updated by Matt Robinson.
I haven't been able to merge this because the tests don't pass. It looks like
the last commit in the series introduces an assumption that a file will exist
in /etc/opt/csw/pkgutil.conf. The code is in the provider in a way that it's
not possible to stub since this file existence assumption is in place outside
of any method calls in the provider.
─ % rspec spec/unit/provider/package/pkgutil_spec.rb
/Users/matthewrobinson/work/puppet/spec/../lib/puppet/util/autoload.rb:87:in
`load': Could not autoload package: Could not autoload
/Users/matthewrobinson/work/puppet/spec/../lib/puppet/provider/package/pkgutil.rb:
No such file or directory - /etc/opt/csw/pkgutil.conf (Puppet::Error)
from
/Users/matthewrobinson/work/puppet/spec/../lib/puppet/util/autoload.rb:75:in
`each'
from
/Users/matthewrobinson/work/puppet/spec/../lib/puppet/util/autoload.rb:75:in
`load'
from
/Users/matthewrobinson/work/puppet/spec/../lib/puppet/metatype/manager.rb:124:in
`type'
from
/Users/matthewrobinson/work/puppet/spec/unit/provider/package/pkgutil_spec.rb:5
from
/Library/Ruby/Gems/1.8/gems/rspec-core-2.5.1/lib/rspec/core/configuration.rb:386:in
`load'
from
/Library/Ruby/Gems/1.8/gems/rspec-core-2.5.1/lib/rspec/core/configuration.rb:386:in
`load_spec_files'
from
/Library/Ruby/Gems/1.8/gems/rspec-core-2.5.1/lib/rspec/core/configuration.rb:386:in
`map'
from
/Library/Ruby/Gems/1.8/gems/rspec-core-2.5.1/lib/rspec/core/configuration.rb:386:in
`load_spec_files'
from
/Library/Ruby/Gems/1.8/gems/rspec-core-2.5.1/lib/rspec/core/command_line.rb:18:in
`run'
from
/Library/Ruby/Gems/1.8/gems/rspec-core-2.5.1/lib/rspec/core/runner.rb:55:in
`run_in_process'
from
/Library/Ruby/Gems/1.8/gems/rspec-core-2.5.1/lib/rspec/core/runner.rb:46:in
`run'
from
/Library/Ruby/Gems/1.8/gems/rspec-core-2.5.1/lib/rspec/core/runner.rb:10:in
`autorun'
from /usr/bin/rspec:19
Also very odd is that when I tried to merge or rebase this branch, I got merge
conflicts even though all the changes should be to the same file. It looks
like there may have been some cherry picking of patches out of order? For
example this patch series doesn't make sense:
- apkg = pkg
+ apkg = Hash.new(pkg)
- apkg = Hash.new(pkg)
+ apkg = pkg.dup
- apkg = Hash.new(pkg)
+ apkg = pkg
I think I can resolve it all correctly with Hash.new being the desired state at
the end, but it's weird that this branch has merge conflicts present within
itself. I've not seen that before.
I'll see if I can figure out a good way to get the test passing on this
tomorrow to get it into Statler before we do an RC, but it may not happen.
----------------------------------------
Feature #4258: Add pkgutil provider
https://projects.puppetlabs.com/issues/4258
Author: James Turnbull
Status: Ready For Testing
Priority: Normal
Assignee: Matt Robinson
Category: Solaris
Target version: Statler
Affected Puppet version: 0.25.5
Keywords: communitypatch
Branch: https://github.com/domcleal/puppet/tree/tickets/master/4258-dev
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
