Jira (PDB-5381) Sync is bouncing nodes silently

[Austin Blatt (Jira)]

Title: Message Title

Austin Blatt updated an issue   PuppetDB / PDB-5381 Sync is bouncing nodes silently Change By: Austin Blatt Sync is bouncing nodes, and creating unnecessary calls to the currently expensive `has-newer-record-for-certname?`. Because it has the record already, the check is true and it does not enqueue the command. This results in a count of {{0}} for the nodes entity even though it did all the work of transferring and vetting a command, but just didn't enqueue it. The discrepancy is between the handling of ttls between {{produce-streaming-body}} which gets called by the query endpoint and {{stream-query-result}} which gets called by the trapperkeeper endpoint. {{produce-streaming-body}} properly handles the context, and turns it into {{query-config}} [as expected|https://github.com/puppetlabs/puppetdb/blob/1957cf44704a78540ca91fcf4f70fcc8629415cc/src/puppetlabs/puppetdb/query_eng.clj#L379] {code} query-config (select-keys context [:node-purge-ttl :add-agent-report-filter]) {code} In {{steam-query-result}} the node-purge-ttl setting needed to properly set the inactive_nodes CTE for the query is in the {{context}}. But we [strip it out|https://github.com/puppetlabs/puppetdb/blob/1957cf44704a78540ca91fcf4f70fcc8629415cc/src/puppetlabs/puppetdb/query_eng.clj#L234] before proceeding to turn the AST into SQL. {code} (select-keys context [:log-queries :query-id]) {code} {code} Add Comment   This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.425277.1638294616000.16015.1641588900265%40Atlassian.JIRA.