Issue #8265 has been updated by Jeff McCune. Status changed from Accepted to In Topic Branch Pending Merge Assignee set to Jeff McCune Keywords set to cloudpack
# Topic Branch # In topic branch `ticket/master/8265_hide_platform_option` in my cloudpack repository on github. <pre> commit 1ad35250ca57552cd8b3342d9bd4b8dc3d2afc8f Author: Jeff McCune <[email protected]> Date: Fri Jul 8 16:11:43 2011 -0700 (#8265) Make the platform flag optional The platform flag currently has only one valid value of 'AWS' This change makes the user facing option optional. The option validation code has been changed to set the platform option to AWS if it's unset. => RFC : The majority of effort on this ticket was writing a valid test to make sure the option is not required. The platform must be specified to Fog and I found it incredibly hard to identify a location in the Faces API where I could test the behavior I was looking for. I suspect this may be because of the decorator pattern in use. The existing spec tests call the action directly in order to test the behavior of the option validation. This doesn't feel right to me, but I've followed the pattern by mocking the Puppet::CloudPack.create_connection method, which is a thin wrapper to Fog itself. Reviewed-by: Dan Bode </pre> Patch mailed to tech. ---------------------------------------- Feature #8265: Remove platform flag entirely https://projects.puppetlabs.com/issues/8265 Author: Jeff McCune Status: In Topic Branch Pending Merge Priority: High Assignee: Jeff McCune Category: Target version: Keywords: cloudpack Branch: Roadmapped: No The only valid choice is "AWS" This option should be entirely removed so the end user does not think we support something more than AWS EC2 at release. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
