Issue #8341 has been updated by Trevor Vaughan.

Update with actual information!

Nigel - No, only pluginsync is set to true, factsync isn't defined at all.

It looks like I put my check in the wrong place last time which is why I was 
seeing the same data for the caller. Sorry about that.

What seems to be actually happening is that, once the facts are sync'd, Puppet 
is looking in both the module space and the local fact space and loading all 
modules.

The culprit seems to be line 17 of facter.rb referenced above.

<code>
dirs = module_fact_dirs + Puppet[:factpath].split(":")
</code>

Should the code be loading items with the same name twice, or should the local 
facts win over the module facts.

I think the second is the correct method since you could have a PM controlled 
by a higher level PM that potentially provides different local facts with the 
same name as the facts in the module space in the lower level PM.

So, not a huge bug, but a potential cause of non-deterministic behavior in 
stacked PM's.
----------------------------------------
Bug #8341: Loading facts repeatedly
https://projects.puppetlabs.com/issues/8341

Author: Trevor Vaughan
Status: Needs More Information
Priority: Normal
Assignee: Jacob Helwig
Category: 
Target version: 
Affected Puppet version: 2.7.2rc1
Keywords: custom fact, repeated
Branch: 
https://github.com/jhelwig/puppet/tree/ticket/master/8341-do-not-explicitly-load-all-facts/


Puppet seems to be getting overzealous when loading custom facts.

Example:

<pre>
Loading facts in custom_fact_1
Loading facts in custom_fact_2
Loading facts in custom_fact_3
Loading facts in custom_fact_5
Loading facts in custom_fact_7
Loading facts in custom_fact_8
Loading facts in custom_fact_9
Loading facts in custom_fact_10
Loading facts in custom_fact_11
Loading facts in custom_fact_12
Loading facts in custom_fact_13
Loading facts in custom_fact_14
Loading facts in custom_fact_5
Loading facts in custom_fact_7
Loading facts in custom_fact_2
Loading facts in custom_fact_3
Loading facts in custom_fact_12
Loading facts in custom_fact_11
Loading facts in custom_fact_10
Loading facts in custom_fact_8
Loading facts in custom_fact_13
Loading facts in custom_fact_6
Loading facts in custom_fact_14
Loading facts in custom_fact_9
Loading facts in custom_fact_1
Loading facts in custom_fact_1
Loading facts in custom_fact_2
Loading facts in custom_fact_3
Loading facts in custom_fact_5
Loading facts in custom_fact_6
Loading facts in custom_fact_7
Loading facts in custom_fact_8
Loading facts in custom_fact_9
Loading facts in custom_fact_10
Loading facts in custom_fact_11
Loading facts in custom_fact_12
Loading facts in custom_fact_13
Loading facts in custom_fact_14
Loading facts in custom_fact_5
Loading facts in custom_fact_7
Loading facts in custom_fact_2
Loading facts in custom_fact_3
Loading facts in custom_fact_12
Loading facts in custom_fact_11
Loading facts in custom_fact_10
Loading facts in custom_fact_8
Loading facts in custom_fact_13
Loading facts in custom_fact_6
Loading facts in custom_fact_14
Loading facts in custom_fact_9
Loading facts in custom_fact_1
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to