Issue #1643 has been updated by Maciej Bliziński.

Hello Nigel,

Here's some background:

* pkgadd/pkgrm are the core, native Solaris package manager tools, which do not 
offer much functionality, and need to be wrapped with other tools to meet real 
life's demands
* pkg-get is an apt-get workalike written by Phil Brown
* pkgutil is another apt-get workalike, written by Peter Bonivart, a 
replacement for pkg-get
* Sunfreeware, Blastwave and OpenCSW are packaging projects, which utilize 
pkg-get or pkgutil, or both

Phil's point, as I understand it, was that the Solaris package providers in 
Puppet need to be named after the utility they wrap, and not after packaging 
projects that happen to use it.

Issue #4258 tracked progress in the pkgutil provider.  If there is a need or a 
special interest to create a pkg-get provider, it could be tracked here.  For 
practical purposes, pkgutil functionality is a superset of pkg-get's.  If there 
are 'sunfreeware' or 'blastwave' or 'opencsw' providers using pkg-get, they 
should be renamed to match the name of the tool.

Here's the rundown of existing Solaris related providers and my suggestions:

* root / lib / puppet / provider / package / sunfreeware.rb -- currenty is an 
alias for blastwave.pp. AFAIK, only pkg-get is compatible with sunfreeware. I'd 
suggest creating a 'pkgget.rb' provider (from blastwave.pp) and making 
sunfreeware an alias for it (or removing sunfreeware.rb)
* root / lib / puppet / provider / package / sun.rb -- wraps pkgadd/pkgrm; the 
more precise but less familiar name could be 'svr4'. At this point, Sun as a 
company is gone, but the pkgadd/pkgrm tools remain.
* root / lib / puppet / provider / package / blastwave.rb -- currently wraps 
pkg-get, should be removed or converted to an alias to the more modern pkgutil 
provider
* root / lib / puppet / provider / package / pkgutil.rb -- is named correctly, 
no change needed. It can be used with Blastwave and OpenCSW.

Maciej
----------------------------------------
Bug #1643: package providers "sunfreeware" and "blastwave" inappropriate: 
should be pkgget
https://projects.puppetlabs.com/issues/1643

Author: Philip Brown
Status: Needs More Information
Priority: Normal
Assignee: Nigel Kersten
Category: package
Target version: 
Affected Puppet version: 0.24.4
Keywords: 
Branch: 


I've noticed that you have two separate "package providers":
puppet/provider/package/sunfreeware.rb
puppet/provider/package/blastwave.rb

This doesnt make sense, since the actual package mechanism is "pkg-get", and is 
common to both of them.
Just as you provide a "dpkg" provider, it seems most appropriate that you 
should provide a "pkgget" provider.

Additionally, as the author of pkg-get, I take exception to the description in 
"blastwave.rb", describing it as "Blastwave's pkg-get".

It does not belong to blastwave. pkg-get belongs to me, specifically. 

Would you please remove both the sunfreeware.rb and blastwave.rb providers, and 
replace them with a generic "pkgget" or "pkg-get" provider file?

a sample version (untested) is provided.




-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to