Issue #9639 has been updated by Thomas Linkin.
It looks good to me. I guess it could be more strict, but anybody that starts their hostnames with a period or a hyphen will have other problems to worry about anyway. I don;t think the overkill is necessary here. ---------------------------------------- Bug #9639: bad mcollectivepe init.pp regex https://projects.puppetlabs.com/issues/9639 Author: Thomas Linkin Status: In Topic Branch Pending Merge Priority: Normal Assignee: Jeff McCune Category: modules Target version: PE 1.2.2 Keywords: Branch: https://github.com/puppetlabs/puppetlabs-mcollectivepe/pull/3 Affected URL: Affected PE version: In the file /opt/puppet/share/puppet/modules/mcollectivepe/manifests/init.pp, there is a regex on line 34 that does not account for all types of hostnames as per [[http://www.freesoft.org/CIE/RFC/1123/14.htm]]. Simple edit: 34: validate_re($fact_stomp_server, '^[a-zA-Z]\w*') new 34: validate_re($fact_stomp_server, '^[0-9]|[a-zA-Z]\w*') -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
