Issue #2518 has been updated by Jacob Helwig.

Status changed from In Topic Branch Pending Review to Tests Insufficient
Assignee deleted (Nick Lewis)

Ohad,

Looking at the pull request the commit message would need to be cleaned up to 
follow the guidelines in 
[CONTRIBUTING.md](https://github.com/puppetlabs/puppet/blob/master/CONTRIBUTING.md),
 and would need to add at least one test around this behavior to make sure it 
doesn't accidentally get broken.

I'm also a bit concerned about how this would interact with people's existing 
databases if they upgrade to a version with this change, largely because I'm 
unaware of how this will really interact with people's storedconfigs setups 
(this is definitely information that belongs in the commit message).  Is there 
anything other than storedconfigs that will be affected by this?
----------------------------------------
Feature #2518: store datetime fields in UTC instead of localtime
https://projects.puppetlabs.com/issues/2518

Author: Ohad Levy
Status: Tests Insufficient
Priority: Low
Assignee: 
Category: stored configuration
Target version: 
Affected Puppet version: 0.24.8
Keywords: 
Branch: 
http://github.com/nicklewis/puppet/tree/feature/0.25.x/2518-store_datetime_in_utc


Curretnly the store config option stores the last_compile etc fields with local 
time, it would be useful to store it in UTC when having multiple puppetmasters 
/ locations.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to