Issue #2888 has been updated by Jason Antman.

Chris Price wrote:
> Jason,
> 
> In the original report, it looks like the client was continuing to log "Run 
> of Puppet configuration client already in progress" at the expected 
> intervals.  Just to make sure I understand correctly, you are not seeing this 
> sort of message, correct?
> 
> If not, then it seems possible that your problem may not have to do with the 
> lock files not being removed; we might want to create a new ticket.

Chris, the original reporter said he was running puppet via cron, so it sounds 
like he's talking about one puppet process leaving the lockfile and the next 
process seeing the stale lockfile with the old PID, and giving that message. I, 
on the other hand, run puppetd as a daemon, so I never get that message. It 
just sits there. And sits... and sits... and sits. 

I'm open to doing absolutely any debugging you want. Next week, time allowing, 
I'm going to roll a few test VMs of identical configuration, run them with all 
debugging enabled, and hope to reproduce the problem. In the mean time, if 
there's any way I can do the ruby equivalent of a memory/heap dump, if that 
would help, I'll try it.

Also, given the behavior I explained, I'm inclined to think that puppetd was in 
the process of applying change(s) when it hung.
----------------------------------------
Bug #2888: puppetd doesn't always cleanup lockfile properly
https://projects.puppetlabs.com/issues/2888#change-55176

Author: Peter Meier
Status: Accepted
Priority: Normal
Assignee: 
Category: plumbing
Target version: 
Affected Puppet version: 0.25.1
Keywords: 
Branch: 


ok I had the patch #2661 now running for some weeks and I had nearly no 
problems anymore. However from time to time (maybe once,twice a week) a random 
client doesn't remove its lockfile (@/var/lib/puppet/state/puppetdlock@), hence 
future runs fail. I assume this might still happen due to a uncatched exception 
(as in #2261), however the problem is a) hard or nearly impossible to reproduce 
and b) it occurs really by random. The only thing I can see in the logs:

<pre>
Nov 30 19:27:41 foobar puppetd[26228]: Finished catalog run in 98.79 seconds
Nov 30 20:00:02 foobar puppetd[3000]: Could not retrieve catalog from remote 
server: Error 502 on SERVER: <html>^M <head><title>502 Bad 
Gateway</title></head>^M <body bgcolor="white">^M <center><h1>502 Bad 
Gateway</h1></center>^M <hr><center>nginx/0.6.39</center>^M </body>^M </html>^M
Nov 30 20:00:03 foobar puppetd[3000]: Using cached catalog
Nov 30 20:00:03 foobar puppetd[3000]: Could not retrieve catalog; skipping run
Nov 30 20:00:04 foobar puppetd[12169]: Run of Puppet configuration client 
already in progress; skipping
Nov 30 20:30:04 foobar puppetd[21230]: Run of Puppet configuration client 
already in progress; skipping
</pre>

as I run puppetd by cron twice an hour with --splay I assume that the run 
between 19:30 and 20:00 got delayed till 20:00. At this time (20:00) a 
puppetmaster restart happens and due to that the 502 occured. This was the run 
of pid 3000, the next run (pid 12169) failed, this could either be as pid 3000 
was still running or because there was already no puppetd anymore running and 
the lock file haven't been removed. However every future run failed as well as 
the lockfile wasn't removed.

So somehow puppet doesn't remove lockfiles properly under certain conditions.

PS: If you think it's better to reopen the old bugreport, close this one and 
duplicate and re-open #2261


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to