Issue #12914 has been updated by Daniel Pittman. Status changed from In Topic Branch Pending Review to Merged - Pending Release
I have merged the change. I half expected it to sleep for some time - a second, up to maybe five - in the Windows call, and not really at all on the Ruby side, which would allow signals to be handled without too much delay, but that implementation looks pretty reasonable, and is certainly safe enough to put into the RC. ---------------------------------------- Bug #12914: Don't block indefinitely in WaitForSingleObject https://projects.puppetlabs.com/issues/12914#change-56123 Author: Josh Cooper Status: Merged - Pending Release Priority: Normal Assignee: Josh Cooper Category: windows Target version: 2.7.x Affected Puppet version: Keywords: Branch: https://github.com/puppetlabs/puppet/pull/556 When creating a child process on Windows, we're calling the WaitForSingleObject with an INFINITE timeout, which means ruby can't be interrupted, e.g. Ctrl-C, until the child process exits. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
