Issue #15420 has been updated by Daniel Pittman.
I think this should be rejected, or at least the code as-is should be: Puppet Labs can't control the code that receives the report, and this is a public API, imposing this (relatively) short timeout for response puts a new burden on the external system. If this was only applied to the HTTP *open* timeout, that wouldn't be so bad - it is the *read* timeout that concerns me. (Though it still has some concerns in that case, too.) It would also be relatively acceptable if the master would not just discard the report when this request failed. Since it will do that, and the entire report will be lost, we should strive to be extremely tolerant of problems with external systems, even at the cost of overall throughput. ---------------------------------------- Bug #15420: puppet master resource starvation on http report url timeouts instead of failures https://projects.puppetlabs.com/issues/15420#change-67350 Author: Ramon Alteren Status: Investigating Priority: Normal Assignee: Category: reports Target version: Affected Puppet version: 2.7.13 Keywords: Branch: We recently had an issue with puppetdashboard that caused it to timeout instead of fail / succeed. Since the default http timeout in ruby is set to 60 seconds, the puppetmaster process is busy for the entire catalog-handling + and additional 60secs to wait on report http post timeout. This causes severe resource starvation on the master resulting in failed puppet runs for _all_ nodes It would make sense to add a timeout parameter for http reports or in the long run split off http reporting into a separate thread/process on the master... -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
