Issue #19247 has been updated by Adrien Thebo.

I was able to track down the original backstory behind this change.


- - -

The change to console logging conventions was a part of a couple of overlapping 
discussions.

Firstly, the work being done on the module tool had need of "undecorated" 
output, where the base color was neutral (white on black, black on white) and 
where output could be done without decoration.  This forced changes in the core 
logging mechanism when a few internal parties strongly objected to the use of a 
different logging mechanism.

Those objections resulted in the decisions to remove the "notice:" prefix from 
that logging level, to reduce the amount of color used in output (allowing it 
to accent the data, rather than overpower the data), and to move away from a 
default set of colors which were arbitrarily chosen to work well in Luke's 
terminal to a deliberately chosen set of colors (based on uncustomized terminal 
renderings and social understandings of color).

"Notice" level messages were asserted to be the most common, least interesting 
form of logging, and rather than adding a new log level for "normal" (which 
would break our adherence to standard Syslog levels), "notice" became 
"neutral".  This was intended to be the first step of several, where we 
continued to differentiate machine-facing and human-facing log output (e.g. 
automatically turning colors on and off), and to refine Puppet's logging to be 
increasingly human-friendly (without breaking machine-facing output). That plan 
has yet to be actualized.

At this point, I don't personally care what colors the log levels have 
associated with them.  On the one hand, it's easy enough to make the claim that 
this is a deliberate breaking change introduced with the 3.0.0 release; on the 
other hand, it's also easy enough to call it an experiment, a mistake, or a 
bug.  My own stake in the work is ensuring that the PMT (and other command line 
tools in Puppet's ecosystem) have a reasonable, blessed way of doing 
undecorated log output, and that any changes made to the core coloring don't 
cause regressions in the PMT.

----------------------------------------
Bug #19247: puppet no longer colorizes notice-level output
https://projects.puppetlabs.com/issues/19247#change-83700

Author: Patrick Schless
Status: Needs Decision
Priority: Normal
Assignee: 
Category: color
Target version: 3.x
Affected Puppet version: 3.0.0
Keywords: 
Branch: https://github.com/puppetlabs/puppet/pull/1472


When upgrading from 2.7.17 to 3.1.0, I no longer get the cyan coloring of 
notice-level output (which is the bulk of puppet's output in my case). The cyan 
coloring is very helpful for distinguishing between capistrano noise and the 
content I'm interested in.

The issue is at lib/puppet/util/log/destinations.rb:116, where the relationship 
between levels and colors includes {:notice => :reset} instead of {:notice => 
:notice}.

This affects both console output and html output.

I only use stand-alone puppet, so I don't know if this issue applies to a 
puppetmaster setup.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to