Issue #18029 has been updated by R. Arruda. Status changed from Needs More Information to In Topic Branch Pending Review Assignee changed from R. Arruda to eric sorenson
Hei, I've now reworked the patch and submitted a pull request. https://github.com/puppetlabs/puppet/pull/1507 Hopefully it looks better now, but i'm not sure about the processing of all flags. I can probably do some extra testing in the next couple of days regarding the pip provider. Let me know if there is more i should do to get the patch accepted, or if there is more into the contribution process, as #1 and #2 should now be in place. Regards, Renato ---------------------------------------- Feature #18029: Install Options for PIP package provider (incl. patch) https://projects.puppetlabs.com/issues/18029#change-84157 Author: R. Arruda Status: In Topic Branch Pending Review Priority: Normal Assignee: eric sorenson Category: package Target version: Affected Puppet version: 3.0.1 Keywords: improvement pip Branch: Hey, Due to some special requirements in my environment i need support for custom install options in PIP (and the PIP provider). I wrote a small patch to the pip package provider to support the feature i needed (custom install options sent to pip). Here is an example of what I needed: <pre> package {'carbon': ensure => installed, provider => 'pip', require => Package['python-twisted'], install_options => ['--prefix=/home/user/graphite', '--install-lib=/home/user/graphite/libs'], } </pre> So I extended the package provider locally to support such syntax. And I'd like to get it integrated upstream. I've tested and it works well for me here, using debian6. Here is the patch: (same patch in unified format is included as an attached file) <pre> 12c12 < has_feature :installable, :uninstallable, :upgradeable, :versionable --- > has_feature :installable, :uninstallable, :upgradeable, :versionable, > :install_options 81a82,86 > end > end > if @resource[:install_options] > @resource[:install_options].each do |install_option| > args << "--install-option="+install_option </pre> If this doesnt follow puppet's style or guidelines, feel free to point me to them. :) -Renato -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
