Issue #16686 has been updated by Daniele Sluijters.

Could someone at least update: 
http://docs.puppetlabs.com/guides/file_serving.html#ip-addresses then? It's 
confusing people now since it's telling them it's only a bug in 3.0.x.

----------------------------------------
Bug #16686: File-Serving Configuration parser does not implement allow_ip 
statements in fileserver.conf
https://projects.puppetlabs.com/issues/16686#change-98210

* Author: Wolfgang Miedl
* Status: Accepted
* Priority: Normal
* Assignee: 
* Category: fileserving
* Target version: 3.x
* Affected Puppet version: 3.0.0
* Keywords: 
* Branch: 
----------------------------------------
In the current 3.0.0 release, the file serving configuration parser incorrectly 
handles "allow_ip" statements in fileserver.conf. Both an allow and allow_ip 
statement will result in Puppet::FileServing::Configuration::Parser.allow being 
called, which again calls Puppet::Network::AuthStore.allow.

This will raise an AuthStoreError in case of an allow_ip statement, as 
Puppet::Network::AuthStore::Declaration.parse fails to parse the parameter. The 
fix is to call Puppet::Network::AuthStore.allow_ip instead in case an allow_ip 
statement is read, which will delegate the parsing to the correct method 
(Puppet::Network::AuthStore::Declaration.parse_ip)

The attached diff illustrates the issue and a possible fix.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to