Issue #20281 has been updated by Josh Cooper.

Target version changed from 3.x to 3.4.0

This issue has multiple parts.

First, the remembered value from the registry always overwrites the command 
line value. As a result, command line options are ignored. This is fixed in 
commit 
[3b07de7ca9051b170a30](https://github.com/puppetlabs/puppet_for_the_win/commit/3b07de7ca9051b170a30).

Second, puppet.conf should be the source of truth instead of the registry for 
puppet related settings. For example, if puppet.conf is changed after it is 
installed.

Third, we are using `createLine` instead of `addLine` to manage puppet.conf 
properties. As a result, we never overwrite an existing setting (when entered 
in the GUI or command line).

----------------------------------------
Bug #20281: Windows installer command line options should overwrite existing 
settings
https://projects.puppetlabs.com/issues/20281#change-98724

* Author: Josh Cooper
* Status: Accepted
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 3.4.0
* Affected Puppet version: 2.7.6
* Keywords: windows msi
* Branch: 
----------------------------------------
When the Windows MSI is uninstalled, the old puppet.conf is left behind. When 
you next install (or during an upgrade) the GUI gives you the option to 
re-enter the puppet master, but any value you enter is ignored, which is very 
surprising.

I would expect that the GUI display the value that is currently in puppet.conf, 
or default to puppet as it does now. And if I specify a value in the GUI, it 
should overwrite the value in puppet.conf. And same if the property is 
specified on the command line.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to