Issue #22972 has been updated by Josh Cooper. Status changed from Unreviewed to Accepted Target version set to 3.5.0 Affected Puppet version set to 2.7.12 Branch set to https://github.com/puppetlabs/puppet/pull/2021
Thanks for the patch Glenn! I've added a link to your PR, it would be great if you could resubmit with the changes we talked about. ---------------------------------------- Bug #22972: Windows Puppet Agent Service gracefully terminates after succesfully being put into a Paused state https://projects.puppetlabs.com/issues/22972#change-101243 * Author: Glenn Sarti * Status: Accepted * Priority: Low * Assignee: * Category: * Target version: 3.5.0 * Affected Puppet version: 2.7.12 * Keywords: windows service agent * Branch: https://github.com/puppetlabs/puppet/pull/2021 ---------------------------------------- If you successfully pause the Windows Puppet Agent Server, then after a period of time the Puppet Agent service will gracefully stop. This does not appear to be appropriate behaviour. The service should remain in a paused state until a Continue or Stop message is sent to the service. It looks like it's to do with the following lines; while running? do return if state != RUNNING According to ruby doco [1] running? is defined as the service is in a RUNNING, PAUSED or IDLE state, but the following line terminates the main loop if the service is not in the running state. It seems that the "return if state != RUNNING" line is not really required [1] http://rubydoc.info/gems/win32-service/0.8.2/frames -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
