Jira (PDB-472) For commands submission, avoid unpacking and repacking JSON just to add annotations

[Kenneth Barber (JIRA)]

Title: Message Title

Kenneth Barber created an issue   PuppetDB / PDB-472 For commands submission, avoid unpacking and repacking JSON just to add annotations Issue Type: Improvement Assignee: Unassigned Created: 24/Feb/14 8:13 AM Priority: Normal Reporter: Kenneth Barber We should try to avoid the extra unpacking/packaging we do at a JSON level during commands submission. If you take a look at enqueue-raw-command! https://github.com/puppetlabs/puppetdb/blob/master/src/com/puppetlabs/puppetdb/command.clj#L235-L256 you can see that we are only unpacking to add these annotations. A better method would be to do one of two things: Figure out if we can attach metadata to the message itself. There is an attributes field in clamq publish that might do the trick: https://github.com/sbtourist/clamq#message-producers ... but generally JMS messages should support the concept of headers with application specific metadata, so if we can store it with the message but not in the body that would be perfect. Perhaps we can just wrap the command itself inside another JSON document, avoiding the need for unwrapping the command until its received by the command processing thread. This should also go hand-in-hand for future support for streaming to MQ (not possible with ActiveMQ today it seems) if we choose to do that later on. Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.