Jira (HI-223) Hiera 'deeper' merge knockout only knocks out from closest array

[Andrew Noonan (JIRA)]

Title: Message Title

Andrew Noonan created an issue   Hiera / HI-223 Hiera 'deeper' merge knockout only knocks out from closest array Issue Type: Bug Assignee: Unassigned Created: 06/Mar/14 1:05 PM Priority: Normal Reporter: Andrew Noonan Consider the following hiera structure: host.yaml stuff: - ---alpha - ---beta - gamma datacenter.yaml stuff: - alpha global.yaml stuff: - beta Where the hierarchy is: :hierarchy: - host - datacenter - global What you'd expect is that a hiera_hash() call from the host matching the host.yaml is that alpha and beta would be knocked out, leaving just gamma in the resulting array. Instead, both gamma and beta are left in. This seems to be because the deep merge is performed in the most specific to least specific order, and the deep_merge gem will delete from the source array knockout values if they match destination values or not. Because they are removed from the array, when the next array is merged (an array that may contain a value to be knocked out), the knockout value is gone. This likely also adds a side-effect (I haven't tested, but it seems correct) that if a value exists multiple times in various files, it is only knocked out in the "closest" array to the knockout value, and is then promptly added back in when seen again. A possible solution to this would be to reverse the processing order for deep_merge so that the knockouts are processed from least specific to more specific, but I suspect there will be tons of other side effects. Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.