Jira (PUP-1983) contain causes edges with nil targets to be added to the catalog

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on an issue   Re: contain causes edges with nil targets to be added to the catalog When I run this on master (targeting 3.7) - the first example results in a circular error: Notice: Scope(Class[Profile::Test]): containing test Notice: Compiled catalog for henriks-macbook-pro.local in environment production in 0.02 seconds Error: Could not apply complete catalog: Found 2 dependency cycles: (Class[Profile::Test] => Class[Profile::Test]) (Class[Profile::Test] => Class[Profile::Test]) Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz And the second example works without errors: Notice: Scope(Class[Profile::Test]): containing test Notice: Scope(Class[Test]): class test Notice: Compiled catalog for henriks-macbook-pro.local in environment production in 0.02 seconds Notice: Finished catalog run in 0.05 seconds In PUP-121, we are changing the behavior of include, require and contain to always make references absolute. This to ensure that these confusing problems occur. I don't know what is causing Error: undefined method `ref' for nil:NilClass on node chell.nedap.local (did you try it with --trace ?), but I can guess that it could be because it splits the absolute name and ends up with a nil segment (such problems have been corrected on master, but I am not sure if that is the cause here) Add Comment   Puppet / PUP-1983 contain causes edges with nil targets to be added to the catalog With certain manifests, interestingly enough not all of them, using contain causes nil edges to be added to the catalog. {noformat} class profile::apt {   contain apt   contain apt::backports   contain apt::unattended_upgrades } {noformat} This causes a nil edge to appear in the catalog from {{Class\[Apt\]}} to nothing. Using this pattern, wh... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.