Jira (PUP-777) Start deprecating 'versionRequirement' per code comment

[Pieter van de Bruggen (JIRA)]

Title: Message Title

Pieter van de Bruggen commented on an issue   Re: Start deprecating 'versionRequirement' per code comment Sorry for the thread necromancy. versionRequirement was produced by older versions of Geppetto, which caused some problems with the work we did for Geordi. As a compromise solution, we accepted their key name and they promptly updated Geppetto to emit the correct key. The question of deprecating the key is somewhat more difficult: the people who most need to see the deprecation warnings are module authors who are either a) using ancient versions of Geppetto or b) writing metadata.json files by hand and using older Geppetto modules as their template. Introducing a deprecation warning (at least at that particular location in the code) will issue a warning any time Puppet does anything with one of these older modules installed, potentially yielding several warnings (one per module) for tasks unrelated to modules (like puppet apply -e). Officially, we've never supported versionRequirement. The offending modules noted above all belong to dhoppe, and I'd be interested in knowing how many of those are "current" versions (within the 3 most recent releases). Add Comment   Puppet / PUP-777 Start deprecating 'versionRequirement' per code comment in 3.x, module.rb says the following: {code}       # NOTICE: The fallback to `versionRequirement` is something we'd like to       # not have to support, but we have a reasonable number of releases that       # don't use `version_requirement`. When we can deprecate this, we should. {code} This should be slated for warnings in 3.5 and removal in 4.0. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.