Jira (PDB-566) PR (125): Ensure db and db users created before validation - rickerc

[gepetto-bot (JIRA)]

Title: Message Title

gepetto-bot commented on an issue   Re: PR (125): Ensure db and db users created before validation - rickerc tdb commented: Another "me too". ``` Notice: /Stage[main]/Puppetdb::Server::Validate_db/Postgresql::Validate_db_connection[validate puppetdb postgres connection]/Exec[validate postgres connection for localhost/puppetdb]/returns: Unable to connect to defined database using: /usr/bin/psql --tuples-only --quiet -h localhost -U puppetdb -p 5432 --dbname puppetdb Error: echo 'Unable to connect to defined database using: /usr/bin/psql --tuples-only --quiet -h localhost -U puppetdb -p 5432 --dbname puppetdb ' && false returned 1 instead of one of [0] Error: /Stage[main]/Puppetdb::Server::Validate_db/Postgresql::Validate_db_connection[validate puppetdb postgres connection]/Exec[validate postgres connection for localhost/puppetdb]/returns: change from notrun to 0 failed: echo 'Unable to connect to defined database using: /usr/bin/psql --tuples-only --quiet -h localhost -U puppetdb -p 5432 --dbname puppetdb ' && false returned 1 instead of one of [0] Notice: /Stage[main]/Puppetdb::Database::Postgresql/Postgresql::Server::Db[puppetdb]/Postgresql::Server::Role[puppetdb]/Postgresql_psql[CREATE ROLE "puppetdb" ENCRYPTED PASSWORD 'xDyfygrgxnphey1jLutccjt2lwsmms' LOGIN NOCREATEROLE NOCREATEDB NOSUPERUSER CONNECTION LIMIT -1]/command: command changed '' to 'CREATE ROLE "puppetdb" ENCRYPTED PASSWORD 'XXXXXX' LOGIN NOCREATEROLE NOCREATEDB NOSUPERUSER CONNECTION LIMIT -1' Notice: /Stage[main]/Puppetdb::Database::Postgresql/Postgresql::Server::Db[puppetdb]/Postgresql::Server::Database_grant[GRANT puppetdb - all - puppetdb]/Postgresql::Server::Grant[database:GRANT puppetdb - all - puppetdb]/Postgresql_psql[GRANT ALL ON DATABASE "puppetdb" TO "puppetdb"]/command: command changed '' to 'GRANT ALL ON DATABASE "puppetdb" TO "puppetdb"' ``` You can clearly see the validation is done before the role is created and the permissions set up. So it's just an ordering issue. @kbarber maybe in your case the order just happens to work out better? The right fix would appear to be ensuring the database is fully set up before validation is done. Please reopen the issue. Add Comment   PuppetDB / PDB-566 PR (125): Ensure db and db users created before validation - rickerc    h2. Ensure db and db users created before validation  * Author: Chris Ricker <>  * Company:  * Github ID: [rickerc|https://github.com/rickerc]  * [Pull Request 125 Discussion|https://github.com/puppetlabs/puppetlabs-puppetdb/pull/125]  * [Pull Request 125 File Diff|https://github.com/puppetlabs/puppetlabs-puppetdb/pull/125/files] h2. Pull Re... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.