Jira (PUP-3301) concat type/provider broken since 3.7.1

[Adrien Thebo (JIRA)]

Title: Message Title

Adrien Thebo commented on an issue   Re: concat type/provider broken since 3.7.1 The reason that this regression occurred is because the types in question were relying on undefined behavior of resource title formats, and were not correctly using the autorequire system. The first autorequire block comes from https://github.com/aroth-arsoft/puppet-type-concat/blob/8afc90a128081a7ebd4992d01333f3984177c7a8/concat/lib/puppet/type/concat_fragment.rb#L240 and I'm going to add annotations to indicate what's going on. autorequire(:concat_fragment) do This indicates that we are going to be returning a list of strings that are resource titles for concat_fragment instances. This means that this should return a list like so: ["concat2_1_3", "concat2_1_2", "concat2_1_1"] req = [] provider.register catalog.resources.each do |r| if r.is_a?(Puppet::Type.type(:concat_fragment)) if r[:parent] == self[:name] req.push(r.to_s) This is our first problem. Instead of storing the resource title, it is storing the resource reference, resulting in this return value: ["Concat_fragment[concat2_2]", "Concat_fragment[concat2_1]", "Concat_fragment[concat2_3a]", "Concat_fragment[concat2_3b]"] This was relying on the undocumented expansion of resource references into resources. end end end sources = self[:source] if sources sources = [sources] unless sources.is_a?(Array) sources.each do |source| uri = URI.parse(URI.escape(source)) if uri.scheme == 'file' path = Puppet::Util.uri_to_path(uri) When we declared this autorequire block we passed a resource type to indicate that we were autorequiring instances of concat_fragment resources. However here we start looking for resources of type concat_file. This should be extracted to a separate autorequire block declared as autorequire(:concat_file). r = catalog.resource(:concat_file, path) if r req << r else This has the same issue as above - we should not be autorequiring resources with a type other than concat_fragment here. The only way this was possible was to return the resource reference, which would magically convert the string into the right type, but it relied on undefined behavior. r = catalog.resource(:file, path) if r #req << r end end req.push(path) end end end info 'autorequire concat_fragment req=' + req.inspect req end The end result of the existing code would return a set of resource references of varying type, while it should have returned a set of resource titles and not included any type information - that should have been determined by the argument passed to the autorequire block. The autorequire for concat_file demonstrates the same issues. Add Comment   Puppet / PUP-3301 concat type/provider broken since 3.7.1 I set up a GIT repository at https://github.com/aroth-arsoft/puppet-type-concat with my concat type+provider. When i'm running the run_concat_test script using puppet version 3.7.0 (or before) the script creates two files: /tmp/concat_test2 which contains concat1 concat2 concat3 and /tmp/concat_test_redir concat1 concat2 concat2_1 concat2_1... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.