Jira (PUP-1165) Spurious 'trigger changed' messages generated by scheduled task provider

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on an issue   Re: Spurious 'trigger changed' messages generated by scheduled task provider There are different behaviors depending on whether you are running 3.7.x or an earlier version. To reproduce the problem: On 3.6.2, create a scheduled task whose trigger start_date is in the past. This simulates what puppet would do if it had run in the past and didn't specify a start_date: scheduled_task { 'spurious_task': ensure => 'present', command => 'c:\windows\system32\notepad.exe', enabled => 'true', trigger => {'every' => '1', 'schedule' => 'daily', 'start_time' => '15:16', 'start_date' => '1999-01-01'}, user => 'system', working_dir => 'c:\windows\system32', } Apply the manifest and it correctly creates the scheduled task: C:\work\puppet>bundle exec puppet apply manifest.pp Notice: Compiled catalog for win-agent.solar.lan in environment production in 0.06 seconds Notice: /Stage\[main\]/Main/Scheduled_task\[spurious_task\]/ensure: created Notice: Finished catalog run in 0.33 seconds Now remove start_date from the trigger: trigger => {'every' => '1', 'schedule' => 'daily', 'start_time' => '15:16' }, And reapply, puppet will generate a 'triggered changed' message: C:\work\puppet>bundle exec puppet apply manifest.pp Notice: Compiled catalog for win-agent.solar.lan in environment production in 0.06 seconds Notice: /Stage\[main\]/Main/Scheduled_task\[spurious_task\]/trigger: trigger changed '{'every' => '1', 'schedule' => 'daily', 'start_date' => '1999-1-1', 'start_time' => '15:16'}' to '[{'every' => '1', 'schedule' => 'daily', 'start_time' => '15:16'}]' Notice: Finished catalog run in 0.31 seconds Puppet will also update the start_date field of the task to today's date: C:\work\puppet>schtasks /query /tn spurious_task /fo list /V | findstr "Date:" Start Date: 10/3/2014 So subsequent puppet runs will see that the task is insync. C:\work\puppet>bundle exec puppet apply manifest.pp Notice: Compiled catalog for win-agent.solar.lan in environment production in 0.06 seconds Notice: Finished catalog run in 0.28 seconds However, as soon as puppet runs tomorrow, it will again think the trigger is out of sync, and update it. And this is what happens with the 'pe-mcollective-metadata' scheduled task. On 3.7.x, the problem is worse. If you try to update the trigger for a task, it will fail with an error. This issue is being tracked in PUP-3203. To reproduce, create a scheduled task: scheduled_task { 'spurious_task': ensure => 'present', command => 'c:\windows\system32\notepad.exe', enabled => 'true', trigger => {'every' => '1', 'schedule' => 'daily', 'start_time' => '15:00' }, user => 'system', working_dir => 'c:\windows\system32', } Apply the manifest: C:\work\puppet>bundle exec puppet apply manifest.pp Notice: Compiled catalog for win-agent.solar.lan in environment production in 0.12 seconds Notice: /Stage\[main\]/Main/Scheduled_task\[spurious_task\]/ensure: created Notice: Finished catalog run in 0.08 seconds Note the start_date and start_time: C:\work\puppet>schtasks /query /tn spurious_task /fo list /V | findstr /C:"Start Time" Start Time: 3:00:00 PM C:\work\puppet>schtasks /query /tn spurious_task /fo list /V | findstr /C:"Start Date" Start Date: 10/3/2014 Change start_time in the manifest, and reapply: C:\work\puppet>bundle exec puppet apply manifest.pp Notice: Compiled catalog for win-agent.solar.lan in environment production in 0.11 seconds Error: no implicit conversion from nil to integer Error: /Stage[main]/Main/Scheduled_task[spurious_task]/trigger: change from {'every' => '1', 'schedule' => 'daily', 'start_date' => '2014-10-3', 'start_time' => '15:00'} to [{'every' => '1', 'schedule' => 'daily', 'start_time' => '15:01'}] failed: no implicit conversion from nil to integer The only recourse is to delete the task, e.g. 'schtasks /delete /tn spurious_task /f' and re-create it. Add Comment   Puppet / PUP-1165 Spurious 'trigger changed' messages generated by scheduled task provider The Windows scheduled task (scheduled_task) provider will generate spurious messages during Puppet runs which suggest that scheduled task resources are being reapplied during each run even when the task is present and its associated resource has not been modified. The messages in question look like the following: {noformat}notice: /Stage[main]/Schedtas... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.