Jira (PUP-2916) yumrepo fails to honour custom reposdir

[Daniel Sung (JIRA)]

Title: Message Title

Daniel Sung commented on an issue   Re: yumrepo fails to honour custom reposdir So this bug has also been a blocker for me too, so I thought I'd have a quick look to see what was wrong with the provider. I think I can see three issues:. Firstly, the find_conf_value method initializes the PhysicalFile but it is never read/parsed, therefore find_conf_value always returns nil at the moment, no matter whether the reposdir setting in yum.conf is present or not. Secondly, the provider makes the assumption that the custom reposdir is added to an array along with the default directory, where in reality, it replaces the default directory and any repofiles in the default directory are ignored by yum. Lastly, it is also assuming that the custom reposdir can be ignored if the directory doesn't exist and fall back onto the default, wherein reality yum doesn't do this. I have made some changes to the provider that seems to work for me, but it looks like the unit tests make these same (incorrect) assumptions. Add Comment   Puppet / PUP-2916 yumrepo fails to honour custom reposdir With yum.conf containing reposdir=/etc/yum.repos.d/custom all was well with 3.4.3 and puppet managed the repo files correctly. Since the 3.5 changes to yumrepo, it no longer uses the custom repodir, so writes the repo files to the wrong directory (/etc/yum.repos.d). But then yum isn't reading them from this directory, so none of them are picked up ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.