Jira (PUP-4073) rundir and logdir are no longer relative to vardir

[Christopher Price (JIRA)]

Title: Message Title

Christopher Price commented on PUP-4073   Re: rundir and logdir are no longer relative to vardir OMG, run_mode. Josh Cooper Jeff McCune I looked at the commit and I understand the issue now, and I guess I'm OK with the proposed path for now, but it's disconcerting. Basically, the problem we have today is that the implementation of 'run_mode' is tightly coupled with the user account, and that's just totally, totally backwards for Puppet Server... because we will never be running as root, but we always want the root-user version of the paths. If we stick with the current direction of things, it will mean that we need to duplicate every run_mode-related setting in puppetserver.conf, and pass them all in to the ruby code when we boot up. Before, that list was limited to one or two settings (confdir/vardir), and now it looks like we're talking about increasing that to 4. The user will have to potentially be aware of this and may need to modify these settings in two places. We are also at risk of the 'puppet master --configprint' command line tool returning invalid results for these settings. I've suffered through the pain associated with that part of the code base enough to know how tricky it is to deal with, so if this is the path of least resistance and everyone thinks it's the only timely way to get things finished up, I won't argue too much. But it feels pretty ugly and risky. I wonder if there's some other way that we could handle this such that the decision about the run_mode (during early boot up of the process) wouldn't be so tightly coupled to the UID of the process? Like, what if we tweaked things so that the only two args that Puppet Server passed into the ruby code were '- confdir' and some new flag like ' run-mode'. Then we could tweak Puppet so that in the spot where it determines the default run mode, it'd notice that cli flag and override the normal behavior? Skip the user check and put us into 'master' run_mode right away? This would be an improvement on the current releases in that we wouldn't even need to pass ' vardir' any longer, in addition to avoiding the need to add ' logdir' and ' -rundir' on top of everything else. It'd also allow us to get rid of some hacky code in Puppet Server where we have to force the run mode to 'master' after the settings have already all been loaded with 'agent/user' run_mode, as it works today. Thoughts? Add Comment   This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.