Jira (PUP-4078) puppet resource tool output contains incorrect quoting

[Geoff Williams (JIRA)]

Title: Message Title

Geoff Williams created an issue   Puppet / PUP-4078 puppet resource tool output contains incorrect quoting Issue Type: Bug Affects Versions: PUP 3.7.4 Assignee: Unassigned Components: Platform Created: 2015/03/03 6:25 PM Environment: 3.7.4 (Puppet Enterprise 3.7.2) Priority: Normal Reporter: Geoff Williams Overview puppet resource currently outputs quotes around values such as 'false' which should logically equate to true unless there are additional measures in place to parse out known values before continuing. Problems this causes As part of the preparation for PE 4.x which includes optional typing, we need to help educate users not to write code which is ambiguous or needs additional processing to work correctly. It's important that the RAL tool generates good puppet code because: Its often the first puppet code a user will see (output by installer) Its output be used for reverse engineering systems and can end up becoming deeply embedded into a codebase Worked example Inspecting the pe-puppet service - note quoting around boolean (and reserved word?): [root@xagent1 ~]# puppet resource service pe-puppet service { 'pe-puppet': ensure => 'running', enable => 'true', } Change the pe-puppet daemon to be stopped with puppet resource -e service pe-puppet Check output of puppet resource command again, note quoting as above [root@xagent1 ~]# puppet resource service pe-puppet service { 'pe-puppet': ensure => 'stopped', enable => 'false', } Corrective action booleans should not be quoted reserved words should not be quoted Add Comment   This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.