Jira (PDB-1589) If JSON null is passed in as a fact value to replace facts v4 then facts endpoint no longer works

[James Stocks (JIRA)]

Title: Message Title

James Stocks created an issue   PuppetDB / PDB-1589 If JSON null is passed in as a fact value to replace facts v4 then facts endpoint no longer works Issue Type: Bug Assignee: Unassigned Attachments: NullFact.json Components: PE Created: 2015/06/04 6:59 AM Priority: Normal Reporter: James Stocks Noticed this during QA of Puppet Enterprise... To reproduce: Send the attached JSON to replace facts v4 (note that osfamily has a JSON null value - this was due to a bug in our test data generator tool) Expected behaviour: I'm not sure. Either null should be accepted and handled by PuppetDB; or the replace facts command should reject the JSON Actual behaviour: replace facts appears to complete successfully Subsequently calling the facts endpoint results in a 200 OK but no payload (note that a node with zero facts returns an empty list [] - in this case there isn't even an empty list) PuppetDB log shows the following exception: 2015-06-03 05:53:40,290 ERROR [p.p.query-eng] Error streaming response clojure.lang.ExceptionInfo: Input to deserialize-fact-value does not match schema: [(named {:value (not (instance? java.lang.String nil))} row)] at puppetlabs.puppetdb.query.facts$eval21253$deserialize_fact_value__21254.invoke(facts.clj:31) ~[na:na] at clojure.core$map$fn__4551.invoke(core.clj:2622) ~[puppetdb-release.jar:na] at clojure.lang.LazySeq.sval(LazySeq.java:40) ~[puppetdb-release.jar:na] at clojure.lang.LazySeq.seq(LazySeq.java:49) ~[puppetdb-release.jar:na] Various parts of the PE Enterprise Console (including node detail) don't work correctly Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.