So, I thought I fixed #1178[1], but turns out, not so much. I expect this is going to be mostly gibberish to everyone, but I have to make the effort.
Thinking a bit (and hopefully sufficiently) more deeply about it, I think I have the right answer, but I wanted some validation or something. Here's what I think the behaviour *should* be: When using normal AST nodes: Use the current 'search tons of names' ability, where we search the cert name, fqdn, short name, long name, porn name, etc. When using external nodes: Use the cert name. That's it. Individual external node providers (e.g., ldap) can provide some modification, such as searching for the short name if the cert name looks like a domain name, but it's up to the terminus. Any terminus that looks for multiple names (again, e.g., ldap) must still return a node instance with its name set to the requested name, which will always be the cert name. This would not change the behaviour at all except for those using external nodes (either exec or ldap), and then only if your external node db does not use the cert name as the node name. However, here's the current behaviour: Always search all node names all the time, and save the node with whatever name we find. Yay. This introduces a problem, because we always save the node with the name it was found by (this is an aspect of the caching and cannot be changed without significant and ugly hackery), and we sometimes find nodes not by their cert name (e.g., when 'node_name' is set to 'facter'). The only change I made, which I thought fixed #1178, was to move the name-collection stuff to the Node class, rather than the XMLRPC handler, and then reset the node name once it was found. This doesn't help, though, because the node has already been saved by the time the name gets reset. 1 - http://reductivelabs.com/redmine/issues/show/1178 -- The most likely way for the world to be destroyed, most experts agree, is by accident. That's where we come in; we're computer professionals. We cause accidents. --Nathaniel Borenstein --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
