-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Daniel Pittman wrote: > Luke Kanies <[EMAIL PROTECTED]> writes: >> On Jul 23, 2008, at 10:12 PM, Daniel Pittman wrote: >>> Luke Kanies <[EMAIL PROTECTED]> writes: >>>> You're doubling up on the work here -- you don't need the >>>> target.delete if you're only assigning when the value isn't :undef. >>> Sure we do: if the parent scope set the variable then a child scope is >>> supposed to remove it when the value is :undef, right? >>> >>> This implements that behaviour. (Unless I misunderstood something) >> You're right; sorry. >> >>>>> [...] >>>>> - unless FileTest.exists?(@file) >>>>> + unless FileTest.exists?(file) >>>>> raise Puppet::ParseError, >>>>> "Could not find template %s" % file >>>>> end >>>> Note that Ruby 1.9 EOLs FileTest.exists?, for some stupid reason. >>>> I've been trying to stick to FileTest.exist? for this reason. >>> I can change that also, if you wish; the choice of test was in the >>> existing code. Preferences? >> If that's the only change, it's not worth redoing just for that. >> >> It's just a point worth making, as at some point we'll have to change >> the whole code base. > > No problem. It seems like the code is considered acceptable now; what > is the best path for y'all to get access to it? > > I can probably set up a git daemon for you to pull the branch from, if > you wish, or can upload the two patches to redmine. The development > guide doesn't cover this, unfortunately.
Git best but happy to have it attached to the ticket as patches. Generally either is acceptable. Regards James P.S. Are you the Aussie Daniel Pittman? - -- Author of: * Pulling Strings with Puppet (http://www.amazon.com/gp/product/1590599780/) * Pro Nagios 2.0 (http://www.amazon.com/gp/product/1590596099/) * Hardening Linux (http://www.amazon.com/gp/product/1590594444/) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIiaoU9hTGvAxC30ARAnkmAJ4kQXAXIqKTVpt8YwyXoBQugrLGiQCdFP6l /97HX5hftr5Aichb5uRpeUU= =RGCn -----END PGP SIGNATURE----- --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
