This is going to require a change to the xmlrpc protocol, whilst
Puppet::FileServing::Metadata in theory supports multiple checksum_type - it
doesn't work correctly at the moment but I've fixed that in the first patch on
this branch.
lib/puppet/file_serving/metadata.rb | 6 +++---
spec/unit/file_serving/metadata.rb | 19 +++++++++++++++++--
2 files changed, 20 insertions(+), 5 deletions(-)
When we are describe()ing the source file (used by insync?) in
type/file/source.rb we call the server:
desc = server.describe(path, @resource[:links])
Which is served by the interface in fileserver.rb:
iface.add_method("string describe(string, string)")
This in turn calls FileServing::Metadata to get the information. However we
need to communicate the desired checksum type, and ensure that is used
throughout (including when we update the checksum in our final write()).
I'm a little uncomfortable about changing the xmlrpc protocol in a point
release and it's possible I've missed something so I wanted to get more
discussion around this issue.
I guess we could make the server describe() return all supported checksum types
and let the client pick which one it wants to check, but that seems a little
heavy handed.
Paul
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
