On 16/10/08 21:59, Luke Kanies wrote:
> On Oct 16, 2008, at 2:54 PM, Brice Figureau wrote:
>
>> On 16/10/08 21:28, Luke Kanies wrote:
>>> On Oct 16, 2008, at 1:37 PM, Brice Figureau wrote:
>>>
>>>> --- /dev/null
>>>> +++ b/test/data/snippets/arraytrailingcomma.pp
>>>> @@ -0,0 +1,3 @@
>>>> +file {
>>>> + ["/tmp/arraytrailingcomma1","/tmp/arraytrailingcomma2"]:
>>>> content => "tmp"
>>>> +}
>>>> \ No newline at end of file
>>>
>>> Shouldn't this snippet actually, um, having a trailing comma?
>> Let's say that was to check that you are actually reading the
>> patches I
>> send :-)
>
> Got lucky this time. :)
You seem to have good eyes.
>> I'll fix this tomorrow.
>>
>>> And any idea why so many of your files seem to be missing newlines at
>>> the end?
>> I personally don't mind and don't pay attention to this.
>> Should I care?
>
> Not sure; git seems to, but I'm not sure I should trust its opinion.
I found why git cares:
ISO C++ Standard says:
2.1/1.2 "If a source file that is not empty does not end in a new-line
character, or ends in a new-line character immediately preceded by a
backslash character, the behavior is undefined".
Since the parser you wrote does seem immune, I think we're safe, but
I'll try to pay attention to this from now on.
Hum, I'm wondering if I can update the ruby and puppet textmate bundle
to highlight the end of file if there is no newline.
Now that I think about it, I also have to check that my pupet textmate
bundle supports all the additions I made to the puppet language :-(
--
Brice Figureau
Days of Wonder
http://www.daysofwonder.com
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
