On 16/10/08 19:54, Brice Figureau wrote: > Hi, > > I just discovered that the fix for #1202 (and particularly the fact that > I added a tags method to TemplateWrapper) broke the following test: > should return the processed template contents with a call to result > and > should set all of the scope's variables as instance variables
Hum, that's strange, I can't seem to reproduce the failing tests anymore :-( Everything is passing now. Even rewinding my dev branch to when I issued the tests can't make them fail... > I didn't perform a thorough analysis, but it is beacause TemplateWrapper > is used as a log source. Log sources are asked for their tags by calling > the tags method. In the case of TemplateWrapper it is plain wrong to do so. > > I'm seeing two options: > * fix the test themselves (I don't think that's the right solution :-)) > or > * rename TemplateWrapper.tags to TemplateWrapper.get_tags or sth else. > > Any other idea? > Let me know and I'll contribute a fix patch. But I still think the behavior I contributed which matched the original request for #1115 is wrong. I'll post a complementary patch in a subsequent e-mail to this thread. -- Brice Figureau Days of Wonder http://www.daysofwonder.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
