On Mon, Dec 1, 2008 at 11:39 AM, Brice Figureau
<[EMAIL PROTECTED]> wrote:
>
> On 1/12/08 19:33, Nigel Kersten wrote:
>> On Mon, Dec 1, 2008 at 10:07 AM, Brice Figureau
>> <[EMAIL PROTECTED]> wrote:
>>> On 1/12/08 18:31, Nigel Kersten wrote:
>>>> On Sun, Nov 30, 2008 at 7:22 PM, James Turnbull <[EMAIL PROTECTED]> wrote:
>>>>> Nigel
>>>>>
>>>>> The new "computer" types tests are a little broken:
>>>> Are you still getting these errors James? Was it due to me including 
>>>> ruby-debug?
>>>>
>>>> I just tested on an Ubuntu install and it seems to be working fine.
>>>>
>>>> # lsb_release -a
>>>> No LSB modules are available.
>>>> Distributor ID:       Ubuntu
>>>> Description:  Ubuntu 8.04.1
>>>> Release:      8.04
>>>> Codename:     hardy
>>>>
>>>> # ./spec/unit/type/computer.rb
>>>> .............
>>>>
>>>> Finished in 0.028797 seconds
>>>>
>>>> 13 examples, 0 failures
>>>>
>>>> I'm getting other errors in Puppet::Parser::Functions and
>>>> Puppet::Node::Catalog from your jamtur01/0.24.x branch that don't seem
>>>> related though.
>>> The Puppet::Parser::Functions are certainly mine (since this test file
>>> didn't exist before #1741). Can you send them to me, as I don't get any
>>> on macosx?
>>
>> sure. I don't get these errors on macosx either though Brice. Just on
>> Ubuntu Hardy.
>>
>> Is this all you wanted?
>>
>> 1)
>> Mocha::ExpectationError in 'Puppet::Parser::Functions when calling
>> newfunction should create the function in the scope class'
>> #<Mock:0x7f79f4ada2a8>.define_method('function_name') - expected
>> calls: 0, actual calls: 1
>> Similar expectations:
>> define_method('function_name', nil)
>
> what Ruby version do you use?
>
> I'm afraid that in my 1.8.6 the block is passed as nil when it doesn't
> exist and in yours nothing is passed...

# ruby --version
ruby 1.8.6 (2007-09-24 patchlevel 111) [x86_64-linux]


>
> Does it work for your ruby version if you change
>
> Puppet::Parser::Scope.expects(:define_method).with("function_name", nil)
>
> by:
> Puppet::Parser::Scope.expects(:define_method).with { |name,block| name
> == "function_name" }
>
> let's say for the first test?

Yep. I also replaced that in all the other tests and they worked after
the change.



-- 
Nigel Kersten
Systems Administrator
Tech Lead - MacOps

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to