2009/1/2 Luke Kanies <[email protected]>: > > I've made the IPMess stuff a lot less messy, and refactored > a lot of the util/ip module, including naming it more sensibly. > > The biggest changes are that I moved the big case statement into > a constant and then used a bit of dispatch-style logic to use it, > and I eliminated a bunch of duplicate code in the ipmess.rb file. > > I've also fixed #1846, in that the interface list now s/:/_/g.
Awesome, this all looks good to me - other than: > diff --git a/lib/facter/util/fact.rb b/lib/facter/util/fact.rb > index ca2ba03..a1d9443 100644 > --- a/lib/facter/util/fact.rb > +++ b/lib/facter/util/fact.rb > @@ -78,6 +78,7 @@ class Facter::Util::Fact > } > > unless foundsuits > + puts "no suitables for %s" % @name This looks like a debugging artifact. > Facter.debug "Found no suitable resolves of %s for %s" % > [[email protected], @name] > end > end > diff --git a/lib/facter/util/ip.rb b/lib/facter/util/ip.rb > index d90c204..c5ec401 100644 Paul --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
