On Thu, Jan 15, 2009 at 11:28 AM, Luke Kanies <[email protected]> wrote:
>
> On Jan 15, 2009, at 1:01 PM, Paul Lathrop wrote:
>
>>
>> Bug in the aliases provider which causes problems if the recipient
>> field contains a ':'
>>
>> Signed-off-by: Paul Lathrop <[email protected]>
>> ---
>> spec/unit/provider/mailalias/aliases.rb | 26 ++++++++++++++++++
>> +++++++
>> test/data/providers/mailalias/aliases/test1 | 28 ++++++++++++++++++
>> +++++++++
>> 2 files changed, 54 insertions(+), 0 deletions(-)
>> create mode 100755 spec/unit/provider/mailalias/aliases.rb
>> create mode 100644 test/data/providers/mailalias/aliases/test1
>>
>> diff --git a/spec/unit/provider/mailalias/aliases.rb b/spec/unit/
>> provider/mailalias/aliases.rb
>> new file mode 100755
>> index 0000000..9d46a17
>> --- /dev/null
>> +++ b/spec/unit/provider/mailalias/aliases.rb
>
> I think this is more of an integration test rather than a unit test.
> I try to have this full-cycle kind of testing in integration.
Okay, I just copied ssh_authorized_key which has an almost identical
test in unit. Want me to move it to integration?
>>
>> @@ -0,0 +1,26 @@
>> +#!/usr/bin/env ruby
>> +
>> +require File.dirname(__FILE__) + '/../../../spec_helper'
>> +
>> +require 'puppettest'
>> +require 'puppettest/support/utils'
>> +require 'puppettest/fileparsing'
>> +
>> +provider_class = Puppet::Type.type(:mailalias).provider(:aliases)
>> +
>> +describe provider_class do
>> + include PuppetTest
>> + include PuppetTest::FileParsing
>> +
>> + before :each do
>> + @provider = provider_class
>> + end
>> +
>> + # #1560
>> + it "should be able to parse each example" do
>> + fakedata("data/providers/mailalias/aliases").each { |file|
>> + puts "Parsing %s" % file
>
> Can you remove this?
Oh, sure. Sorry.
--Paul
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
